From 944f651865be7f9d9ca9ea6e69fa34bc75f1c706 Mon Sep 17 00:00:00 2001 From: Sara Damiano Date: Fri, 7 Feb 2020 13:18:36 -0500 Subject: [PATCH] Changed some format penalties Signed-off-by: Sara Damiano --- .clang-format | 4 +-- src/TinyGsmClientA6.h | 20 +++++++------- src/TinyGsmClientBG96.h | 20 +++++++------- src/TinyGsmClientESP8266.h | 36 ++++++++++++------------- src/TinyGsmClientM590.h | 24 ++++++++--------- src/TinyGsmClientM95.h | 26 +++++++++--------- src/TinyGsmClientMC60.h | 44 ++++++++++++++++--------------- src/TinyGsmClientSIM5360.h | 24 ++++++++--------- src/TinyGsmClientSIM7000.h | 27 ++++++++++--------- src/TinyGsmClientSIM7600.h | 24 ++++++++--------- src/TinyGsmClientSIM800.h | 23 +++++++++------- src/TinyGsmClientSaraR4.h | 24 ++++++++--------- src/TinyGsmClientSequansMonarch.h | 28 ++++++++++---------- src/TinyGsmClientUBLOX.h | 22 ++++++++-------- src/TinyGsmClientXBee.h | 26 +++++++++--------- src/TinyGsmCommon.h | 27 +++++++++++-------- 16 files changed, 206 insertions(+), 193 deletions(-) diff --git a/.clang-format b/.clang-format index 110d35d..60ffff7 100644 --- a/.clang-format +++ b/.clang-format @@ -74,14 +74,14 @@ NamespaceIndentation: None ObjCBlockIndentWidth: 2 ObjCSpaceAfterProperty: false ObjCSpaceBeforeProtocolList: true -PenaltyBreakAssignment: 2 +PenaltyBreakAssignment: 25 PenaltyBreakBeforeFirstCallParameter: 19 PenaltyBreakComment: 300 PenaltyBreakFirstLessLess: 120 PenaltyBreakString: 1000 PenaltyBreakTemplateDeclaration: 10 PenaltyExcessCharacter: 60 -PenaltyReturnTypeOnItsOwnLine: 5 +PenaltyReturnTypeOnItsOwnLine: 50 PointerAlignment: Left PointerBindsToType: true ReflowComments: true diff --git a/src/TinyGsmClientA6.h b/src/TinyGsmClientA6.h index fc89369..3b28a94 100644 --- a/src/TinyGsmClientA6.h +++ b/src/TinyGsmClientA6.h @@ -477,11 +477,11 @@ class TinyGsmA6 */ public: // TODO(vshymanskyy): Optimize this! - uint8_t - waitResponse(uint32_t timeout_ms, String& data, GsmConstStr r1 = GFP(GSM_OK), - GsmConstStr r2 = GFP(GSM_ERROR), - GsmConstStr r3 = GFP(GSM_CME_ERROR), GsmConstStr r4 = NULL, - GsmConstStr r5 = NULL) { + uint8_t waitResponse(uint32_t timeout_ms, String& data, + GsmConstStr r1 = GFP(GSM_OK), + GsmConstStr r2 = GFP(GSM_ERROR), + GsmConstStr r3 = GFP(GSM_CME_ERROR), + GsmConstStr r4 = NULL, GsmConstStr r5 = NULL) { /*String r1s(r1); r1s.trim(); String r2s(r2); r2s.trim(); String r3s(r3); r3s.trim(); @@ -489,7 +489,7 @@ class TinyGsmA6 String r5s(r5); r5s.trim(); DBG("### ..:", r1s, ",", r2s, ",", r3s, ",", r4s, ",", r5s);*/ data.reserve(64); - int index = 0; + uint8_t index = 0; uint32_t startMillis = millis(); do { TINY_GSM_YIELD(); @@ -558,10 +558,10 @@ class TinyGsmA6 return waitResponse(timeout_ms, data, r1, r2, r3, r4, r5); } - uint8_t - waitResponse(GsmConstStr r1 = GFP(GSM_OK), GsmConstStr r2 = GFP(GSM_ERROR), - GsmConstStr r3 = GFP(GSM_CME_ERROR), GsmConstStr r4 = NULL, - GsmConstStr r5 = NULL) { + uint8_t waitResponse(GsmConstStr r1 = GFP(GSM_OK), + GsmConstStr r2 = GFP(GSM_ERROR), + GsmConstStr r3 = GFP(GSM_CME_ERROR), + GsmConstStr r4 = NULL, GsmConstStr r5 = NULL) { return waitResponse(1000, r1, r2, r3, r4, r5); } diff --git a/src/TinyGsmClientBG96.h b/src/TinyGsmClientBG96.h index a255037..0347055 100644 --- a/src/TinyGsmClientBG96.h +++ b/src/TinyGsmClientBG96.h @@ -394,11 +394,11 @@ class TinyGsmBG96 */ public: // TODO(vshymanskyy): Optimize this! - uint8_t - waitResponse(uint32_t timeout_ms, String& data, GsmConstStr r1 = GFP(GSM_OK), - GsmConstStr r2 = GFP(GSM_ERROR), - GsmConstStr r3 = GFP(GSM_CME_ERROR), GsmConstStr r4 = NULL, - GsmConstStr r5 = NULL) { + uint8_t waitResponse(uint32_t timeout_ms, String& data, + GsmConstStr r1 = GFP(GSM_OK), + GsmConstStr r2 = GFP(GSM_ERROR), + GsmConstStr r3 = GFP(GSM_CME_ERROR), + GsmConstStr r4 = NULL, GsmConstStr r5 = NULL) { /*String r1s(r1); r1s.trim(); String r2s(r2); r2s.trim(); String r3s(r3); r3s.trim(); @@ -406,7 +406,7 @@ class TinyGsmBG96 String r5s(r5); r5s.trim(); DBG("### ..:", r1s, ",", r2s, ",", r3s, ",", r4s, ",", r5s);*/ data.reserve(64); - int index = 0; + uint8_t index = 0; uint32_t startMillis = millis(); do { TINY_GSM_YIELD(); @@ -472,10 +472,10 @@ class TinyGsmBG96 return waitResponse(timeout_ms, data, r1, r2, r3, r4, r5); } - uint8_t - waitResponse(GsmConstStr r1 = GFP(GSM_OK), GsmConstStr r2 = GFP(GSM_ERROR), - GsmConstStr r3 = GFP(GSM_CME_ERROR), GsmConstStr r4 = NULL, - GsmConstStr r5 = NULL) { + uint8_t waitResponse(GsmConstStr r1 = GFP(GSM_OK), + GsmConstStr r2 = GFP(GSM_ERROR), + GsmConstStr r3 = GFP(GSM_CME_ERROR), + GsmConstStr r4 = NULL, GsmConstStr r5 = NULL) { return waitResponse(1000, r1, r2, r3, r4, r5); } diff --git a/src/TinyGsmClientESP8266.h b/src/TinyGsmClientESP8266.h index aac5e98..4466e38 100644 --- a/src/TinyGsmClientESP8266.h +++ b/src/TinyGsmClientESP8266.h @@ -219,8 +219,8 @@ class TinyGsmESP8266 RegStatus getRegistrationStatus() { sendAT(GF("+CIPSTATUS")); if (waitResponse(3000, GF("STATUS:")) != 1) return REG_UNKNOWN; - int status = - waitResponse(GFP(GSM_ERROR), GF("2"), GF("3"), GF("4"), GF("5")); + int status = waitResponse(GFP(GSM_ERROR), GF("2"), GF("3"), GF("4"), + GF("5")); waitResponse(); // Returns an OK after the status return (RegStatus)status; } @@ -298,8 +298,8 @@ class TinyGsmESP8266 bool callAnswerImpl() TINY_GSM_ATTR_NOT_AVAILABLE; bool callNumberImpl(const String& number) TINY_GSM_ATTR_NOT_AVAILABLE; bool callHangupImpl() TINY_GSM_ATTR_NOT_AVAILABLE; - bool - dtmfSendImpl(char cmd, int duration_ms = 100) TINY_GSM_ATTR_NOT_AVAILABLE; + bool dtmfSendImpl(char cmd, + int duration_ms = 100) TINY_GSM_ATTR_NOT_AVAILABLE; /* * Messaging functions @@ -382,8 +382,8 @@ class TinyGsmESP8266 bool modemGetConnected(uint8_t mux) { sendAT(GF("+CIPSTATUS")); if (waitResponse(3000, GF("STATUS:")) != 1) { return false; } - int status = - waitResponse(GFP(GSM_ERROR), GF("2"), GF("3"), GF("4"), GF("5")); + int status = waitResponse(GFP(GSM_ERROR), GF("2"), GF("3"), GF("4"), + GF("5")); if (status != 3) { // if the status is anything but 3, there are no connections open waitResponse(); // Returns an OK after the status @@ -394,8 +394,8 @@ class TinyGsmESP8266 } bool verified_connections[TINY_GSM_MUX_COUNT] = {0, 0, 0, 0, 0}; for (int muxNo = 0; muxNo < TINY_GSM_MUX_COUNT; muxNo++) { - uint8_t has_status = - waitResponse(GF("+CIPSTATUS:"), GFP(GSM_OK), GFP(GSM_ERROR)); + uint8_t has_status = waitResponse(GF("+CIPSTATUS:"), GFP(GSM_OK), + GFP(GSM_ERROR)); if (has_status == 1) { int returned_mux = stream.readStringUntil(',').toInt(); streamSkipUntil(','); // Skip mux @@ -419,11 +419,11 @@ class TinyGsmESP8266 */ public: // TODO(vshymanskyy): Optimize this! - uint8_t - waitResponse(uint32_t timeout_ms, String& data, GsmConstStr r1 = GFP(GSM_OK), - GsmConstStr r2 = GFP(GSM_ERROR), - GsmConstStr r3 = GFP(GSM_CME_ERROR), GsmConstStr r4 = NULL, - GsmConstStr r5 = NULL) { + uint8_t waitResponse(uint32_t timeout_ms, String& data, + GsmConstStr r1 = GFP(GSM_OK), + GsmConstStr r2 = GFP(GSM_ERROR), + GsmConstStr r3 = GFP(GSM_CME_ERROR), + GsmConstStr r4 = NULL, GsmConstStr r5 = NULL) { /*String r1s(r1); r1s.trim(); String r2s(r2); r2s.trim(); String r3s(r3); r3s.trim(); @@ -431,7 +431,7 @@ class TinyGsmESP8266 String r5s(r5); r5s.trim(); DBG("### ..:", r1s, ",", r2s, ",", r3s, ",", r4s, ",", r5s);*/ data.reserve(64); - int index = 0; + uint8_t index = 0; uint32_t startMillis = millis(); do { TINY_GSM_YIELD(); @@ -504,10 +504,10 @@ class TinyGsmESP8266 return waitResponse(timeout_ms, data, r1, r2, r3, r4, r5); } - uint8_t - waitResponse(GsmConstStr r1 = GFP(GSM_OK), GsmConstStr r2 = GFP(GSM_ERROR), - GsmConstStr r3 = GFP(GSM_CME_ERROR), GsmConstStr r4 = NULL, - GsmConstStr r5 = NULL) { + uint8_t waitResponse(GsmConstStr r1 = GFP(GSM_OK), + GsmConstStr r2 = GFP(GSM_ERROR), + GsmConstStr r3 = GFP(GSM_CME_ERROR), + GsmConstStr r4 = NULL, GsmConstStr r5 = NULL) { return waitResponse(1000, r1, r2, r3, r4, r5); } diff --git a/src/TinyGsmClientM590.h b/src/TinyGsmClientM590.h index 3cc3edd..8fada7b 100644 --- a/src/TinyGsmClientM590.h +++ b/src/TinyGsmClientM590.h @@ -287,8 +287,8 @@ class TinyGsmM590 bool callAnswerImpl() TINY_GSM_ATTR_NOT_AVAILABLE; bool callNumberImpl(const String& number) TINY_GSM_ATTR_NOT_AVAILABLE; bool callHangupImpl() TINY_GSM_ATTR_NOT_AVAILABLE; - bool - dtmfSendImpl(char cmd, int duration_ms = 100) TINY_GSM_ATTR_NOT_AVAILABLE; + bool dtmfSendImpl(char cmd, + int duration_ms = 100) TINY_GSM_ATTR_NOT_AVAILABLE; /* * Messaging functions @@ -389,11 +389,11 @@ class TinyGsmM590 */ public: // TODO(vshymanskyy): Optimize this! - uint8_t - waitResponse(uint32_t timeout_ms, String& data, GsmConstStr r1 = GFP(GSM_OK), - GsmConstStr r2 = GFP(GSM_ERROR), - GsmConstStr r3 = GFP(GSM_CME_ERROR), GsmConstStr r4 = NULL, - GsmConstStr r5 = NULL) { + uint8_t waitResponse(uint32_t timeout_ms, String& data, + GsmConstStr r1 = GFP(GSM_OK), + GsmConstStr r2 = GFP(GSM_ERROR), + GsmConstStr r3 = GFP(GSM_CME_ERROR), + GsmConstStr r4 = NULL, GsmConstStr r5 = NULL) { /*String r1s(r1); r1s.trim(); String r2s(r2); r2s.trim(); String r3s(r3); r3s.trim(); @@ -401,7 +401,7 @@ class TinyGsmM590 String r5s(r5); r5s.trim(); DBG("### ..:", r1s, ",", r2s, ",", r3s, ",", r4s, ",", r5s);*/ data.reserve(64); - int index = 0; + uint8_t index = 0; uint32_t startMillis = millis(); do { TINY_GSM_YIELD(); @@ -471,10 +471,10 @@ class TinyGsmM590 return waitResponse(timeout_ms, data, r1, r2, r3, r4, r5); } - uint8_t - waitResponse(GsmConstStr r1 = GFP(GSM_OK), GsmConstStr r2 = GFP(GSM_ERROR), - GsmConstStr r3 = GFP(GSM_CME_ERROR), GsmConstStr r4 = NULL, - GsmConstStr r5 = NULL) { + uint8_t waitResponse(GsmConstStr r1 = GFP(GSM_OK), + GsmConstStr r2 = GFP(GSM_ERROR), + GsmConstStr r3 = GFP(GSM_CME_ERROR), + GsmConstStr r4 = NULL, GsmConstStr r5 = NULL) { return waitResponse(1000, r1, r2, r3, r4, r5); } diff --git a/src/TinyGsmClientM95.h b/src/TinyGsmClientM95.h index 5954a31..1b6031a 100644 --- a/src/TinyGsmClientM95.h +++ b/src/TinyGsmClientM95.h @@ -414,9 +414,9 @@ class TinyGsmM95 uint32_t timeout_ms = ((uint32_t)timeout_s) * 1000; sendAT(GF("+QIOPEN="), mux, GF(",\""), GF("TCP"), GF("\",\""), host, GF("\","), port); - int rsp = - waitResponse(timeout_ms, GF("CONNECT OK" GSM_NL), - GF("CONNECT FAIL" GSM_NL), GF("ALREADY CONNECT" GSM_NL)); + int rsp = waitResponse(timeout_ms, GF("CONNECT OK" GSM_NL), + GF("CONNECT FAIL" GSM_NL), + GF("ALREADY CONNECT" GSM_NL)); return (1 == rsp); } @@ -513,11 +513,11 @@ class TinyGsmM95 */ public: // TODO(vshymanskyy): Optimize this! - uint8_t - waitResponse(uint32_t timeout_ms, String& data, GsmConstStr r1 = GFP(GSM_OK), - GsmConstStr r2 = GFP(GSM_ERROR), - GsmConstStr r3 = GFP(GSM_CME_ERROR), GsmConstStr r4 = NULL, - GsmConstStr r5 = NULL) { + uint8_t waitResponse(uint32_t timeout_ms, String& data, + GsmConstStr r1 = GFP(GSM_OK), + GsmConstStr r2 = GFP(GSM_ERROR), + GsmConstStr r3 = GFP(GSM_CME_ERROR), + GsmConstStr r4 = NULL, GsmConstStr r5 = NULL) { /*String r1s(r1); r1s.trim(); String r2s(r2); r2s.trim(); String r3s(r3); r3s.trim(); @@ -525,7 +525,7 @@ class TinyGsmM95 String r5s(r5); r5s.trim(); DBG("### ..:", r1s, ",", r2s, ",", r3s, ",", r4s, ",", r5s);*/ data.reserve(64); - int index = 0; + uint8_t index = 0; uint32_t startMillis = millis(); do { TINY_GSM_YIELD(); @@ -591,10 +591,10 @@ class TinyGsmM95 return waitResponse(timeout_ms, data, r1, r2, r3, r4, r5); } - uint8_t - waitResponse(GsmConstStr r1 = GFP(GSM_OK), GsmConstStr r2 = GFP(GSM_ERROR), - GsmConstStr r3 = GFP(GSM_CME_ERROR), GsmConstStr r4 = NULL, - GsmConstStr r5 = NULL) { + uint8_t waitResponse(GsmConstStr r1 = GFP(GSM_OK), + GsmConstStr r2 = GFP(GSM_ERROR), + GsmConstStr r3 = GFP(GSM_CME_ERROR), + GsmConstStr r4 = NULL, GsmConstStr r5 = NULL) { return waitResponse(1000, r1, r2, r3, r4, r5); } diff --git a/src/TinyGsmClientMC60.h b/src/TinyGsmClientMC60.h index ecb1fd3..4c51552 100644 --- a/src/TinyGsmClientMC60.h +++ b/src/TinyGsmClientMC60.h @@ -237,9 +237,9 @@ class TinyGsmMC60 delay(1000); continue; } - int status = - waitResponse(GF("READY"), GF("SIM PIN"), GF("SIM PUK"), - GF("NOT INSERTED"), GF("PH_SIM PIN"), GF("PH_SIM PUK")); + int status = waitResponse(GF("READY"), GF("SIM PIN"), GF("SIM PUK"), + GF("NOT INSERTED"), GF("PH_SIM PIN"), + GF("PH_SIM PUK")); waitResponse(); switch (status) { case 2: @@ -393,9 +393,9 @@ class TinyGsmMC60 uint32_t timeout_ms = ((uint32_t)timeout_s) * 1000; sendAT(GF("+QIOPEN="), mux, GF(",\""), GF("TCP"), GF("\",\""), host, GF("\","), port); - int rsp = - waitResponse(timeout_ms, GF("CONNECT OK" GSM_NL), - GF("CONNECT FAIL" GSM_NL), GF("ALREADY CONNECT" GSM_NL)); + int rsp = waitResponse(timeout_ms, GF("CONNECT OK" GSM_NL), + GF("CONNECT FAIL" GSM_NL), + GF("ALREADY CONNECT" GSM_NL)); return (1 == rsp); } @@ -493,11 +493,12 @@ class TinyGsmMC60 */ public: // TODO(vshymanskyy): Optimize this! - uint8_t - waitResponse(uint32_t timeout_ms, String& data, GsmConstStr r1 = GFP(GSM_OK), - GsmConstStr r2 = GFP(GSM_ERROR), - GsmConstStr r3 = GFP(GSM_CME_ERROR), GsmConstStr r4 = NULL, - GsmConstStr r5 = NULL, GsmConstStr r6 = NULL) { + uint8_t waitResponse(uint32_t timeout_ms, String& data, + GsmConstStr r1 = GFP(GSM_OK), + GsmConstStr r2 = GFP(GSM_ERROR), + GsmConstStr r3 = GFP(GSM_CME_ERROR), + GsmConstStr r4 = NULL, GsmConstStr r5 = NULL, + GsmConstStr r6 = NULL) { /*String r1s(r1); r1s.trim(); String r2s(r2); r2s.trim(); String r3s(r3); r3s.trim(); @@ -506,7 +507,7 @@ class TinyGsmMC60 String r6s(r6); r6s.trim(); DBG("### ..:", r1s, ",", r2s, ",", r3s, ",", r4s, ",", r5s, ",", r6s);*/ data.reserve(64); - int index = 0; + uint8_t index = 0; uint32_t startMillis = millis(); do { TINY_GSM_YIELD(); @@ -572,19 +573,20 @@ class TinyGsmMC60 return index; } - uint8_t - waitResponse(uint32_t timeout_ms, GsmConstStr r1 = GFP(GSM_OK), - GsmConstStr r2 = GFP(GSM_ERROR), - GsmConstStr r3 = GFP(GSM_CME_ERROR), GsmConstStr r4 = NULL, - GsmConstStr r5 = NULL, GsmConstStr r6 = NULL) { + uint8_t waitResponse(uint32_t timeout_ms, GsmConstStr r1 = GFP(GSM_OK), + GsmConstStr r2 = GFP(GSM_ERROR), + GsmConstStr r3 = GFP(GSM_CME_ERROR), + GsmConstStr r4 = NULL, GsmConstStr r5 = NULL, + GsmConstStr r6 = NULL) { String data; return waitResponse(timeout_ms, data, r1, r2, r3, r4, r5, r6); } - uint8_t - waitResponse(GsmConstStr r1 = GFP(GSM_OK), GsmConstStr r2 = GFP(GSM_ERROR), - GsmConstStr r3 = GFP(GSM_CME_ERROR), GsmConstStr r4 = NULL, - GsmConstStr r5 = NULL, GsmConstStr r6 = NULL) { + uint8_t waitResponse(GsmConstStr r1 = GFP(GSM_OK), + GsmConstStr r2 = GFP(GSM_ERROR), + GsmConstStr r3 = GFP(GSM_CME_ERROR), + GsmConstStr r4 = NULL, GsmConstStr r5 = NULL, + GsmConstStr r6 = NULL) { return waitResponse(1000, r1, r2, r3, r4, r5, r6); } diff --git a/src/TinyGsmClientSIM5360.h b/src/TinyGsmClientSIM5360.h index e598dfc..47d6c49 100644 --- a/src/TinyGsmClientSIM5360.h +++ b/src/TinyGsmClientSIM5360.h @@ -407,8 +407,8 @@ class TinyGsmSim5360 : public TinyGsmModem(text); @@ -1198,6 +1197,12 @@ class TinyGsmModem { return false; } + void streamClear() { + while (thisModem().stream.available()) { + thisModem().waitResponse(50, NULL, NULL); + } + } + // Yields up to a time-out period and then reads a character from the stream // into the mux FIFO // TODO(SRGDamia1): Do we need to wait two _timeout periods for no